-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix error in asyncapi optimize #1634
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Gourav <[email protected]>
|
We require all PRs to follow Conventional Commits specification.
|
Quality Gate passedIssues Measures |
@GauravSaini01 rule number one when contributing is to followup on automation results. Maintainers will not fix problems for you. So if there is PR title linting failing, tests failing, you need to proactively research solution and fix things to make sure CI/CD automation is green and maintainers can do the review /ptal |
@Amzani @Souvikns @AayushSaini101 @Shurtu-gal Please take a look at this PR. Thanks! 👋 |
Could attach a demo of the solution fixing problem in the original issue? |
Related issue(s)
#1626
Description
Right File Path
Wrong File Path
./asyncapi.yaml
Automatic pick
./asyncapi.yaml
file and handle it similarly to the right file path case./asyncapi.yaml
Wrong Context name
Right Context name
asyncapi optimize
without [spec-file]Pick the file associated with the current context name and handle it similarly to the right file path case
./asyncapi.yaml
presentAutomatic pick
./asyncapi.yaml
file and behave similar to Right File Path case./asyncapi.file
and current context@AayushSaini101 @Shurtu-gal please review my PR