Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error in asyncapi optimize #1634

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GauravSaini01
Copy link
Contributor

Related issue(s)

#1626

Description

Right File Path

Image

Wrong File Path

  • With ./asyncapi.yaml
    Automatic pick ./asyncapi.yaml file and handle it similarly to the right file path case
  • Without ./asyncapi.yaml
    Image

Wrong Context name

Image

Right Context name

  • pick file that is associated with context name and handle it similarly to the right file path case

asyncapi optimize without [spec-file]

  • If current context is set
    Pick the file associated with the current context name and handle it similarly to the right file path case
  • If ./asyncapi.yaml present
    Automatic pick ./asyncapi.yaml file and behave similar to Right File Path case
  • without ./asyncapi.file and current context
    Image

@AayushSaini101 @Shurtu-gal please review my PR

Copy link

changeset-bot bot commented Jan 18, 2025

⚠️ No Changeset found

Latest commit: 47937a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@asyncapi-bot
Copy link
Contributor

We require all PRs to follow Conventional Commits specification.
More details 👇🏼

 No release type found in pull request title "fix error in asyncapi optimize". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@derberg
Copy link
Member

derberg commented Jan 20, 2025

@GauravSaini01 rule number one when contributing is to followup on automation results. Maintainers will not fix problems for you. So if there is PR title linting failing, tests failing, you need to proactively research solution and fix things to make sure CI/CD automation is green and maintainers can do the review

/ptal
solution here relates to code fixes purely, nothing on the command level so in my opinion doesn't really matter as I'm not a maintainer here. Just letting you know that I will not be involved in review 😄

@asyncapi-bot
Copy link
Contributor

@Amzani @Souvikns @AayushSaini101 @Shurtu-gal Please take a look at this PR. Thanks! 👋

@Shurtu-gal
Copy link
Collaborator

Could attach a demo of the solution fixing problem in the original issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

4 participants