-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auth0-vue package is using '@vue/runtime-core' which breaks augmentation of type ComponentCustomProperties in vue apps. #426
Comments
For documentation: This should be fixed with #419 |
I see that this was merged into main, but will there be a new version on npm for this package to fix the issues in my repos? I don't quite understand the process of how this package is maintained and by who so sorry in advance if I'm missing something obvious. |
@tusharpandey13 can we get an npm release? @frgr91 you can point to the latest github repo commit in your package.json while you wait. "@auth0/auth0-vue": "github:auth0/auth0-vue#8443323ee6d213d5aee9d33d1254e249c3006415", EDIT: edited to use the full hash, as per #426 (comment) |
Thanks for the reply, I didn't get this to work in my pnpm monorepo/pipeline. It's not a big issue though, but hopefully this will be published on npm soon enough :) |
Any news on getting this deployed to NPM as well? I'd rather not use a github commit as dependency |
I'll join the thread here. Just created a fresh Vue project and the whole development pipeline is now blocked due to the issue, we need auth0-vue. The npm release is eagerly awaited |
It looks like the release failed - https://github.com/auth0/auth0-vue/actions/runs/12114834286, because this workflow file tries to use another workflow file that does not exist (but there is an action with the same name). auth0-vue/.github/workflows/npm-release.yml Lines 34 to 35 in 1bc5834
Looks like #344 broke the automated release process. |
For anyone looking for a workaround in a Nuxt 3 project. This worked for us. |
ugh, this is a real pain in the ass. I've tried contacting contributors of this package to try to resolve this issue but I'm getting nothing in return. Anyone got any ideas on what to do? |
@frgr91 @andreasgangso Use the full 40 character hash: "@auth0/auth0-vue": "github:auth0/auth0-vue#8443323ee6d213d5aee9d33d1254e249c3006415", |
@poovamraj @desusai7 @tusharpandey13 @eugeniop |
Hello everyone, Thanks for your patience! |
Checklist
Description
In newer vue versions the global properties augmentation has changed from using '@vue/runtime-core' to 'vue'.
The incorrect global property augmentation:
The correct global propery augmentation:
It is described in the vue documentation here: https://vuejs.org/guide/typescript/options-api#augmenting-global-properties
Any package using the augmentation of '@vue/runtime-core' will break and override other packages.
The solution:
Change the module-declaration from '@vue/runtime-core' to 'vue'.
Reproduction
Note: you must also add the property to your vue-instance in order for it to work when compiled:
app.config.globalProperties.$myCustomProperty = 'Hi there'.
Additional context
If any other packages is using '@vue/runtime-core' to augment global property typings it will break the global property augmentation resulting in type-errors.
auth0-vue version
2.3.3
Vue version
3.5.11
Which browsers have you tested in?
Chrome
The text was updated successfully, but these errors were encountered: