Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move autoware_universe_utils to autoware_utils #21

Open
3 tasks done
cyn-liu opened this issue Jan 11, 2025 · 1 comment
Open
3 tasks done

move autoware_universe_utils to autoware_utils #21

cyn-liu opened this issue Jan 11, 2025 · 1 comment
Assignees

Comments

@cyn-liu
Copy link

cyn-liu commented Jan 11, 2025

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

Hi @mitsudome-r @youtalk @xmfcx
I plan to move all the functions in autoware_universe_utils to autoware_utils.

But I found that the names of the functions that have been moved in autoware_utils have changed their naming conventions compared to the original ones.
for example:
origin
now

So, do other functions that need to be moved also need to be renamed??
But I suggest that we should maintain consistency with the original naming convention. What is your opinion?

Purpose

None.

Possible approaches

None.

Definition of done

None.

@cyn-liu cyn-liu self-assigned this Jan 11, 2025
@mitsudome-r
Copy link
Member

Let's use snake case.
https://autowarefoundation.github.io/autoware-documentation/main/contributing/coding-guidelines/languages/cpp/#use-lower-snake-case-for-function-names-required-partially-automated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants