Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple files #19

Open
1 task done
ShikOfTheRa opened this issue Apr 15, 2023 · 9 comments
Open
1 task done

Support for multiple files #19

ShikOfTheRa opened this issue Apr 15, 2023 · 9 comments
Labels
enhancement New feature or request

Comments

@ShikOfTheRa
Copy link

Is there an existing feature request for this?

  • I have searched the existing open and closed issues

Feature description

Most of my flights are > 10 minutes so files are split.

Is it feasible to add support for "joining" of files to produce one final output?

I have produced separate files and tried to join using apps, but they have not been very successful. Usually errors playing.

Many thanks for your time and support for this. Appreciate how much effort goes into the tool
:)

@ShikOfTheRa ShikOfTheRa added the enhancement New feature or request label Apr 15, 2023
@Pairan
Copy link

Pairan commented Apr 27, 2023

... 👍 would come in handy on a 40min flight like mine

@ShikOfTheRa
Copy link
Author

... 👍 would come in handy on a 40min flight like mine

Same here. Tool is still brilliant thought - at least can make them ready to join with something else

@dz0ny
Copy link
Contributor

dz0ny commented Apr 28, 2023

The mp4 is kinda not designed for joining containers, mkv on the other hand is. I have a patch that saves to mkv and then one can use mkvmerge -o output.mkv AvatarS0002_with_osd.mkv + AvatarS0003_with_osd.mkv to join files together, it takes under 1s to join 20min video.

This works too https://www.variadic.xyz/2021/02/05/ffmpeg-concatenate/

@avsaase
Copy link
Owner

avsaase commented Apr 28, 2023

This is definitely planned and it shouldn't be too hard to implement. The thing I'm not sure about is how to incorporate it into the UI. Suggestions are welcome :)

Also, I had some reports that with the current firmware the recorded OSD starts about two seconds late for the second and higher 10 minute clips. In the first clip the OSD gets out of sync near the end but this is easily fixed by adjusting the OSD playback speed to match the duration of the video. For the later clips I need to do more testing to find a suitable workaround/hack untill Caddx fixes the timestamps in the .osd file.

@dz0ny
Copy link
Contributor

dz0ny commented Apr 28, 2023

This is definitely planned and it shouldn't be too hard to implement. The thing I'm not sure about is how to incorporate it into the UI. Suggestions are welcome :)

Also, I had some reports that with the current firmware the recorded OSD starts about two seconds late for the second and higher 10 minute clips. In the first clip the OSD gets out of sync near the end but this is easily fixed by adjusting the OSD playback speed to match the duration of the video. For the later clips I need to do more testing to find a suitable workaround/hack untill Caddx fixes the timestamps in the .osd file.

I was thinking about "Merge videos" button, which is a multi-select open dialogue. One selects the files, the app sorts them and runs the command for join. Later you can add support to the initial open file dialogue.

@mmosca
Copy link
Contributor

mmosca commented Jul 2, 2023

This is definitely planned and it shouldn't be too hard to implement. The thing I'm not sure about is how to incorporate it into the UI. Suggestions are welcome :)

Also, I had some reports that with the current firmware the recorded OSD starts about two seconds late for the second and higher 10 minute clips. In the first clip the OSD gets out of sync near the end but this is easily fixed by adjusting the OSD playback speed to match the duration of the video. For the later clips I need to do more testing to find a suitable workaround/hack untill Caddx fixes the timestamps in the .osd file.

If you pair it with batch processing, a simple checkbox to join the files should be enough.

Add all files to the converter, select join files.

It would still be a minor pain if I had multiple long files, to process, but it would already reduce my repetitive tasks by a lot.

@Pairan
Copy link

Pairan commented Jul 2, 2023

Joining files is really cool and helps on those longer flights where the files are 10min each.

I would like that feature

@Yury-MonZon
Copy link

Yury-MonZon commented Apr 11, 2024

This works for HEVC video files:

ffmpeg -i AvatarG0000_with_osd.mp4 -c copy -bsf:v hevc_mp4toannexb -f mpegts fileIntermediate0.ts


ffmpeg -i AvatarG0001_with_osd.mp4 -c copy -bsf:v hevc_mp4toannexb -f mpegts fileIntermediate1.ts


ffmpeg -i "concat:fileIntermediate0.ts|fileIntermediate1.ts" -c copy -bsf:a aac_adtstoasc mergedVideo.mp4


rm fileIntermediate*.ts

@ShikOfTheRa
Copy link
Author

Anyone interested in this ?
For me the tool would be perfect with this added. Unfortunately my programming skills are a bit rusty :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants