Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Re-write self-managed nodegroups logic #117

Closed
mbeacom opened this issue May 4, 2023 · 2 comments
Closed

Maintenance: Re-write self-managed nodegroups logic #117

mbeacom opened this issue May 4, 2023 · 2 comments

Comments

@mbeacom
Copy link
Contributor

mbeacom commented May 4, 2023

Summary

The self-managed nodegroup logic is currently resulting in nodes that are unable to join the target cluster.
Reproduction steps will be backfilled here when available.

Per #36:

  1. Update self-managed nodegroups using the graceful termination of the node-termination-handler in coordination with the instance refresh functionality of an autoscaling group. This process should be used if the node-termination-handler is deployed within the cluster, the autoscaling group is monitored by the NTH for lifecycle events, and an instance refresh configuration is present on the launch template used by the autoscaling group
  2. Update self-managed nodegroups using logic similar to that of the EKS managed node group (like this)

Why is this needed?

Current workflow is erroneous.

Which area does this relate to?

No response

Solution

Rewrite the logic for self-managed nodegroups into the new core.

@github-actions
Copy link

github-actions bot commented Jun 4, 2023

This issue has not received any attention in 30 days. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions
Copy link

This issue has not received any attention in 30 days. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants