Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change user attribute to JSONObject #50

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

zhu-xiaowei
Copy link
Contributor

  • PR title and description conform to Pull Request guidelines.

Description of changes:

  1. change user attribute to JSONObject

How did you test these changes?
(Please add a line here how the changes were tested)

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei requested a review from zxkane December 13, 2023 06:56
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (88037a0) 87.17% compared to head (5e45dfa) 87.17%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #50   +/-   ##
=========================================
  Coverage     87.17%   87.17%           
  Complexity      447      447           
=========================================
  Files            42       42           
  Lines          1638     1638           
  Branches        149      149           
=========================================
  Hits           1428     1428           
  Misses          133      133           
  Partials         77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zxkane zxkane force-pushed the fix_user_attributes branch from 5e45dfa to 6703964 Compare December 13, 2023 09:17
@zxkane zxkane enabled auto-merge (squash) December 13, 2023 09:17
@zxkane zxkane merged commit d4c1890 into main Dec 13, 2023
3 checks passed
@zxkane zxkane deleted the fix_user_attributes branch December 13, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants