chore(cli): remove legacy compat code to support version reporting in v1 apps #32710
Conversation
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
added
the
pr/needs-cli-test-run
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32710 +/- ##
==========================================
- Coverage 81.38% 81.37% -0.02%
==========================================
Files 222 222
Lines 13750 13693 -57
Branches 2424 2412 -12
==========================================
- Hits 11191 11143 -48
+ Misses 2279 2271 -8
+ Partials 280 279 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
mrgrain
added
pr-linter/cli-integ-tested
|
Pipeline execution: 3d54620c |
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify
bot
deleted the
mrgrain/chore/remove-version-reporting-compat-code
branch
|
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
In the first versions of AWS CDK v1 and older, version metadata was injected by the CLI not by the framework.
This changed with the introduction of Cloud Assembly Schema v6.0.0 in AWS CDK v1.65.0 (see changelog).
The CLI kept compatibility code around to ensure the metadata is injected. This code was introduced via #19010 on Feb 17, 2022.
However this code was intended for v1 and kept around because v1 and v2 were initially developed on the same code base. In the meantime, AWS CDK v1 is EOS and we do not need to support v1 features from v2 anymore.
This change will mean that we will stop reporting metadata for users that use the CLI v2
>= 2.174.0(the release removing the compat code) to deploy a Cloud Assembly developed with framework v1< 1.65.0. Otherwise these users are not functionally effected by the change.We therefore decide to now remove the unused compat code.
Description of changes
Remove the unused legacy code and adjusted test cases.
Describe any new or updated permissions being added
n/a
Description of how you validated changes
Run unit test and CLI integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license