Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that non-Encryption SDK exceptions can be raised #322

Open
alex-chew opened this issue Mar 16, 2021 · 1 comment
Open

Document that non-Encryption SDK exceptions can be raised #322

alex-chew opened this issue Mar 16, 2021 · 1 comment

Comments

@alex-chew
Copy link
Contributor

alex-chew commented Mar 16, 2021

The API documentation for the Python Encryption SDK lists custom exception types, but the APIs may let through exceptions from underlying libraries (e.g. InvalidTag and InvalidSignature) from pyca/cryptography. We should add a note to the documentation stating this.

Alternatively (or additionally) we can try to wrap these kind of exceptions into Encryption SDK custom exceptions with additional context.

@mattsb42-aws
Copy link
Member

Philosophical note from the original author: this was not intentional. I would consider this a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants