💰100$ Bounty - [Paladin] Ardent Defender dual spec issue

[Annamaria-CC]

chromiecraft/chromiecraft#5852

What client do you play on?

enUS

Faction

Alliance

Content Phase:

Generic

Current Behaviour

When swapping talents, ardent defender no longer procs, need to relog for it to work.

That does not seem to be the case

Expected Blizzlike Behaviour

Ardent defender should work when swapping back to prot talents

Source

Steps to reproduce the problem

get 2 specializations
swap to spec with ardent defender
find an enemy
attack it
die

Extra Notes

AC rev. hash/commit

chromiecraft@a779cca

Operating system

Ubuntu 20.04

Modules

• mod-ah-bot
• mod-bg-item-reward
• mod-BreakingNewsOverride
• mod-cfbg
• mod-chat-transmitter
• mod-cta-switch
• mod-desertion-warnings
• mod-duel-reset
• mod-eluna
• mod-instanced-worldbosses
• mod-ip-tracker
• mod-low-level-arena
• mod-low-level-rbg
• mod-multi-client-check
• mod-progression-system
• mod-pvp-titles
• mod-pvpstats-announcer
• mod-queue-list-cache
• mod-rdf-expansion
• mod-transmog
• mod-weekend-xp
• mod-zone-difficulty
• lua-carbon-copy
• lua-event-scripts
• lua-exchange-npc
• lua-level-up-reward
• lua-recruit-a-friend
• lua-send-and-bind
• lua-temp-announcements
• lua-zonecheck

Customizations

None

Server

ChromieCraft

[GastonCK]

So the steps are switch spec, switch back to prot and ardent defender won't work? coz I just did that and it did work.

[Annamaria-CC]

hmm weird. Ill need to check later

[shaszun]

It's not just that, whenever the ardent defender stops working as a tank you start getting tons more dmg. My guess is all passive talents stop working. And bug not trigger all the time, so far since heroic release I got it around 10 times. For me the only fix is to reset talents from the trainer, no dual spec swapping, reloging or whatever worked.

[ghost]

Testing together with Choof today yielded these results:

Respecing to prot with dual spec while inside heroic TBC dungeon (with or without RDF) or inside TBC Raids such as kara causes the Ardent Defender effect to become inactive.
Specing to prot from a blank talent spec (no dual spec) while inside heroic TBC dungeon or TBC raids such as kara causes the Ardent Defender effect to become inactive.
Doing any of this in a normal dungeon, classic dungeon (lvl 60) or outside dungeon will not result in bug.

There seems to be a problem with the game applying the aura belonging to AD when inside dungeons that have been tuned by CC. Please look at the custom nerf auras interfering with this spell.

[Carriola-wotlk]

Are you sure this bug hasn't already been fixed? I was trying to fix it myself, but I noticed that the Ardent Defender effects works correctly, even when changing specs. Here a video:

2024-08-29-20-36-47.mp4

I see that the PR with the fix was merged on September 15th, the same day as the last comment. But the build with the fix probably hadn't been made yet

@Rorschach91 have you tried?

fyi: @Nyeriah

[Nyeriah]

It’s extremely hard to reproduce. I doubt it was fixed.

[Rorschach91]

@Carriola-wotlk I tried to reproduce it inside a dungeon, but ardent defender works well for me.
I agree with @Nyeriah. If this bug is still present It's hard to reproduce.

[Nyeriah]

Did this happen during CC vanilla? How far back was the first occurrence?

[bountyhub-app]

🚀 Bounty Alert!

💰 A bounty of $100.00 has been created by FrancescoBorzi on BountyHub for this issue.

🔗 Claim this bounty by submitting a pull request that solves this issue!

You can also increase the amount of the bounty if you think the issue is worth more.

Good luck, and happy coding! 💻

[EricksOliveira]

If anyone can leave more details on how to reproduce this problem, I would be grateful. I have tested it in several ways. I have tried to reproduce it 500+ times, but without success.

[Annamaria-CC]

back when I triaged the report, it was very easy to reproduce, haven't played lately so wouldn't know if it got fixed somehow now.

[5Buttons]

Considering this only seemed to happen in dungeons and raids on Chromiecraft, I think it might have been a problem with mod-zone-difficulty and was possibly fixed by adding ardent defender to the exception list: azerothcore/mod-zone-difficulty@fbdf316

[Nyeriah]

[EricksOliveira]

It seems to be something specific to a Module. I only have CFBG, Eluna CrossPVE and Playerbots. I have a base of good players who could report this problem, I even sent a message asking more without a response where I came to confirm the problem.

[5Buttons]

After some extensive testing, this bug is consistently reproducible:
Chromie TBC Raids: yes
Chromie TBC dungeons normal/heroic: no //in contrast to the earlier comment from ghost i cant reproduce this bug in heroic TBC dungeons.
Chromie Classic raids/dungeons: no
Outside world: no
When the bug is triggered, it persists. If a paladin enters one of the tbc raids without Ardent Defender then respecs into Ardent Defender and leaves raid-instance then Ardent Defender won't trigger neither in the outside world nor in any other instanced content. You have to relog or respec outside the raid again.
This bug only occurs when Ardent Defender is learned by the player either by putting talent points into the talent tree or by using dual spec. If Ardent Defender is learned through .learn all my talents the bug does not occur.

I am fairly certain mod-zone-difficulty plays a role in this. As only instances are effected where zone_difficulty is enabled.

[EricksOliveira]

The problem is related to mod-zone-difficulty. I did some tests and the problem seems to occur after logging out of the Raid, Ardent Defender stops working properly the second time. Even after leaving the Raid and re-entering it, the error persists. It only resolves after logging out of the Raid. Then Ardent Defender works normally.

[EricksOliveira]

Possible fix. azerothcore/mod-zone-difficulty#57