Bug: %OLD% Match in z_filter_disabled_and_trash.sql is not doing what you want it to do

[atimeforwolves]

Current Behaviour

Line 63: OR UPPER(NAME) LIKE '%OLD%'

Example: Item = Goldthorn
UPPER(Goldthorn) = GOLDTHORN
GOLDTHORN = %OLD%
Goldthorn added to disabled items

This occurs with EVERY item that contains OLD or old (bold, gold, cold, mold, vold, soldier, etc.) All of these items get disabled.

UPPER() does nothing and capitalizing the string as %OLD% does nothing (%old%) will also flag all of these items.

Expected Behaviour

The checks for OLD, NPC, and QA should be changed or removed, and a separate sql command should be made to add the items you are intending to target with these checks to the disabled list.

Here is a list of non BoP items that are getting flagged and disabled from the %OLD% check
https://www.wowhead.com/items/name:gold?filter=82:2;4:2;30305:0#items
https://www.wowhead.com/items/name:old?filter=82:2;4:2;30305:0
https://www.wowhead.com/items/name:bold?filter=82:2;4:2;30305:0
https://www.wowhead.com/items/name:cold?filter=82:2;4:2;30305:0
https://www.wowhead.com/items/name:soldier?filter=82:2;4:2;30305:0

Steps to reproduce the problem

Step 1: Build
Step 2: Select any valid item id with a name that contains old from the disabled list
Step 3: See that they were added from the z_filter_disabled_and_trash.sql file

Extra Notes

No response

AC rev. hash/commit

n/a

Operating system

Debian 12 x64

Custom changes or Modules

No response

[LaertesKrabs]

Thanks for catching this, i've always wondered why there is no gold ore in my auctionhouse!

I've dropped my mod_auctionhousebot_disabled_items table and recreated it, replacing line 63 in z_filter_disabled_and_trash.sql with the following:

OR NAME COLLATE utf8mb4_bin LIKE '%OLD%'

This should only filter for items with OLD in upper case in their name.