Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One failed message in transactions makes whole batch fail #87

Open
KonradStaniec opened this issue Jan 8, 2025 · 1 comment
Open

One failed message in transactions makes whole batch fail #87

KonradStaniec opened this issue Jan 8, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@KonradStaniec
Copy link
Collaborator

KonradStaniec commented Jan 8, 2025

Currently if one messge with sigantures fail then the whole batch fail and it is never retried again without this bad message - https://github.com/babylonlabs-io/covenant-emulator/blob/v0.11.1/covenant/covenant.go#L228

Ideally covenant emulator would:

  • send transaction with batch of messages
  • if tx fail due to one bad message in the batch, this message should be identified and excluded from the batch, and then whole batch should be retried again
@KonradStaniec KonradStaniec added the bug Something isn't working label Jan 8, 2025
@RafilxTenfen RafilxTenfen self-assigned this Jan 9, 2025
@RafilxTenfen
Copy link
Contributor

usual error

expected err when submitting the tx, skip retrying	{"error": "rpc error: code = Unknown desc = rpc error: code = Unknown desc = failed to execute message; message index: 0: the covenant signature is already submitted [cosmos/[email protected]/baseapp/baseapp.go:1023] with gas used: '55521': unknown request"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants