Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: commission-rate required on edit-finality-provider #282

Open
samricotta opened this issue Jan 14, 2025 · 0 comments · May be fixed by #296
Open

bug: commission-rate required on edit-finality-provider #282

samricotta opened this issue Jan 14, 2025 · 0 comments · May be fixed by #296
Assignees
@samricotta

Comments

@samricotta
Copy link
Contributor

samricotta commented Jan 14, 2025 •
edited
Loading

When running edit-finality-provider it requires you to enter the commission-rate, which isn't the desired functionality. If the commission-rate isn't present the following error will occur:

Whoops. There was an error while executing your fpd CLI 'failed to edit finality provider 6d3d0db52eaf19bf47e45ed367c75bcba440bf634c312c2e3223e47a4d81f16c err rpc error: code = Unknown desc = decimal string cannot be empty'%

We should follow Cosmos SDK’s convention which allows empty commission rate in the request.
@samricotta samricotta self-assigned this Jan 21, 2025
@samricotta samricotta linked a pull request Jan 23, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samricotta samricotta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: edit finality provider commission-rate babylonlabs-io/finality-provider
1 participant
@samricotta