Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible run with k gretter than 63 #83

Open
kebern opened this issue Oct 16, 2024 · 5 comments
Open

Possible run with k gretter than 63 #83

kebern opened this issue Oct 16, 2024 · 5 comments
Labels
enhancement New feature or request not planned This will not be worked on

Comments

@kebern
Copy link

kebern commented Oct 16, 2024

Hello,
I would want to run ska2 with k gretter than 63, for example k-mer=81 with in the middle SNP.

Is it possible to ugrade the ska2 with upgraded k?
I try k-mer=81 with ska1 but failed.
If no could you please advise other tools where k-mer value it up to 81.

Thank you.

KB.

@johnlees
Copy link
Member

Max k=63 as that's the largest we can fit in u128, which is the longest base type in rust. It is possible to add longer precision but this would be a fair amount of work for us.

Can I ask exactly why you want to use a longer k-mer length? Typically you will get more recall with lower k, and we'd recommend 17 or 31.

@johnlees
Copy link
Member

I actually think that SKA1 may work with any k-mer length so you could try that. Would still be interested to know why you want/need this

@kebern
Copy link
Author

kebern commented Oct 16, 2024

Thank you Johnlees.
I would like to have a possibility to work with gretter k (like k-mer=81), because at the end I can find the specific SNP for each node after build the tree. That will help to design primers and amplify the k-mer where is selected SNP.

@johnlees
Copy link
Member

Ok interesting, thanks for sharing this.

Unfortunately we don't have the capacity to add this at the moment, but I'll leave this issue open – if lots of people want this feature we could consider adding it in future.

For now, I'd suggesting using SKA1: https://github.com/simonrharris/SKA

@johnlees johnlees added enhancement New feature or request not planned This will not be worked on labels Oct 17, 2024
@kebern
Copy link
Author

kebern commented Oct 17, 2024

Thank you Johnlees.

BK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request not planned This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants