-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question about navigation #132
Comments
OK, I will add a config to allow custom |
Dear Junyao Bai! Thank you for your loyalty and responsiveness. |
OK, I try to do this. |
Now, you can custom link target, please pull the latest code and upgrade. laravel-bjyblog/resources/lang/ru.json Lines 187 to 189 in d764df5
|
Updated, everything works fine. |
Yes, the second option is better. |
Thank you so much! |
The translation has been updated. |
Thank you very much! |
What is the point of using the target = "_ blank" attribute when opening an article or comment?
Maybe it makes sense to make an opening in the current browser tab? If a user views articles and comments, many tabs open.
I have commented out this attribute in the file so far:
/resources/views/home/index/index.blade.php
Line 30:
<a class="b-oa-title" href="{{ $v-> url}} "> <! - target =" _ blank "-> {{$ v-> title}} </a>
Line 75:
<a class=" b-readall" href="{{ $v-> url}} "> <! - target =" _ blank "-> {{__ ('Read More')}} </a>
And in the file:
/resources/views/layouts/home.blade.php
Line 131:
<a class="b-recommend-a" href="{{ $v-> url}} "> <! - target =" _ blank "-> <span class =" fa fa-th-list b- black "> </span> {{$ v-> title}} </a>
Line 145:
{{ __('Comment') }}<a href="{{ $comment->article->url }}#comment-{{ $comment->id }}"> <!--target="_blank"--> → {{ $comment->article->sub_title }}</a>
This element on line 145 → improves the display of comments in the sidebar block. By the way, if it is possible in this block letters in words are also cut off, it would be nice to increase the number of words there and cut off words
Only now when updating these changes will be overwritten ... and you will have to manually make the changes again.
What do you think? It may make sense to remove this attribute so as not to produce many tabs or make this parameter customizable in the admin panel. It would be great to introduce breadcrumbs into the blog ....
https://dev.to/jordanirabor/building-dynamic-breadcrumbs-in-laravel-926
Or this:
https://github.com/davejamesmiller/laravel-breadcrumbs
But probably it is very difficult.
But perhaps you find it necessary to simply remove the target = "_ blank" attribute from the files that I wrote. Your opinion?
Thank you very much for your work!
The text was updated successfully, but these errors were encountered: