Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in commit 6ffe8f3f69d130760ca4746e1bfa8b13bd7aaafa #163

Open
dabeibao opened this issue May 5, 2024 · 0 comments
Open

Regression in commit 6ffe8f3f69d130760ca4746e1bfa8b13bd7aaafa #163

dabeibao opened this issue May 5, 2024 · 0 comments

Comments

@dabeibao
Copy link

dabeibao commented May 5, 2024

Commit 6ffe8f3 introduces a crash when encountering certain erratic monster names in a non-English (Chinese) locale.

After adding some traces, it appears that the length of the monster name exceeds 50 characters.

However, even after enlarging name_str to 128 characters, the crash persists due to illegal Unicode characters in the data contained within d2::hovered_monster_name.

Edit: After switching to non-HD font, the monster name is shown correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant