Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a better way to align / buffer the audio and control data in adcontrol element #4

Open
dholroyd opened this issue Jan 9, 2017 · 0 comments

Comments

@dholroyd
Copy link
Contributor

dholroyd commented Jan 9, 2017

If adcontrol applies volume changes to fade the main audio, I presume that the use of InterpolationControlSource should mean a good line up of the volume changes to the audio.

To stop the InterpolationControlSource instance leaking references to all control points ever added, we just delete any points more than 1 second older than the one being added. There's probably nothing that requires the AD_descriptor control data to arrive at the adcontrol element within 1 second of the audio data for the same timestamp (e.g. there could be >1s buffering in a queue-element on one path that's not there in the other).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant