Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove user migration workflow #1210

Open
4 tasks
rustyjux opened this issue Jan 3, 2025 · 0 comments
Open
4 tasks

Remove user migration workflow #1210

rustyjux opened this issue Jan 3, 2025 · 0 comments
Labels

Comments

@rustyjux
Copy link
Contributor

rustyjux commented Jan 3, 2025

Background

User migration workflows were created to support Keycloak migration from Silver to Gold (see https://dpdd.atlassian.net/issues/APS-1335, #580, #605), namely to add logic to login to migrate a user's Authz permissions from their old user (username@provider) to the new user (user_uuid@provider) and to disable the old user.

This was implemented in v1.2.5 of Portal in Oct 2022 and so all users should be migrated at this point and this functionality (and the associated tests) are likely no longer required.

While working on a Portal Node upgrade, the tests for user migration were leading to Portal crashes and providing the impetus to open this issue.

User migration functionality is in src/services/workflow/migrate-user.ts and referenced by src/auth/auth-oauth2-proxy.js. Tested in e2e/cypress/tests/05-migrate-user/01-migrate-user-access.cy.ts.

A/C

  • confirm user migration workflow is no longer required
    • review old users still in Keycloak (prod)
  • user migration functionality is removed
  • related tests are removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant