From 34ce40a6cc68acebcfa0aeaeae82216d41f7f00f Mon Sep 17 00:00:00 2001 From: PaulGarewal Date: Tue, 30 Jul 2024 12:49:58 -0700 Subject: [PATCH 1/7] incorporation application changes for api spec --- docs/oas/business.yaml | 190 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 190 insertions(+) diff --git a/docs/oas/business.yaml b/docs/oas/business.yaml index 220b02c283..ce289c226a 100644 --- a/docs/oas/business.yaml +++ b/docs/oas/business.yaml @@ -2439,6 +2439,109 @@ paths: type: object properties: {} examples: + incorporation-application-success-response: + summary: Incorporation Application Response + value: + errors: + - null + filing: + business: + identifier: Tqcbbbc157 + header: + accountId: 3445 + affectedFilings: [] + availableOnPaperOnly: false + certifiedBy: API Specs + colinIds: [] + comments: [] + date: '2024-07-25T16:17:57.191108+00:00' + deletionLocked: false + effectiveDate: '2024-07-25T16:17:57.191129+00:00' + email: no_one@never.get + filingId: 150333 + inColinOnly: false + isCorrected: false + isCorrectionPending: false + name: incorporationApplication + status: DRAFT + submitter: mocked submitter + incorporationApplication: + contactPoint: + email: no_one@never.get + phone: 123-456-7890 + nameRequest: + legalType: BEN + nrNumber: 'NR 1345876' + offices: + recordsOffice: + deliveryAddress: + addressCity: delivery_address city + addressCountry: CA + addressRegion: BC + postalCode: H0H0H0 + streetAddress: delivery_address - address line one + mailingAddress: + addressCity: mailing_address city + addressCountry: CA + addressRegion: BC + postalCode: H0H0H0 + streetAddress: mailing_address - address line one + registeredOffice: + deliveryAddress: + addressCity: delivery_address city + addressCountry: CA + addressRegion: BC + postalCode: H0H0H0 + streetAddress: delivery_address - address line one + mailingAddress: + addressCity: mailing_address city + addressCountry: CA + addressRegion: BC + postalCode: H0H0H0 + streetAddress: mailing_address - address line one + parties: + - mailingAddress: + addressCity: Victoria + addressCountry: CA + addressRegion: BC + postalCode: V8W 3E6 + streetAddress: 200-940 Blanshard St + streetAddressAdditional: '' + officer: + email: severin@example.com + firstName: BCREGTEST Lucille + id: 'p90x2145' + lastName: TWENTY + middleName: '' + organizationName: '' + partyType: person + roles: + - appointmentDate: '2024-07-24' + roleType: Completing Party + - deliveryAddress: + addressCity: Burnaby + addressCountry: CA + addressRegion: BC + postalCode: V5E 1R9 + streetAddress: 6767 Burford St + streetAddressAdditional: '' + mailingAddress: + addressCity: Burnaby + addressCountry: CA + addressRegion: BC + postalCode: V5E 1R9 + streetAddress: 6767 Burford St + streetAddressAdditional: '' + officer: + firstName: Director + id: 'p90x2145' + lastName: Test + middleName: '' + organizationName: '' + partyType: person + roles: + - appointmentDate: '2024-07-24' + roleType: Director amalgamation-regular-success-response: summary: Amalgamation Regular Response value: @@ -2780,6 +2883,93 @@ paths: schema: $ref: '#/components/schemas/Filing' examples: + incorporation-application-request: + summary: Incorporation Application Request + value: + filing: + header: + certifiedBy: API Specs + email: no_one@never.get + name: incorporationApplication + date: '{{today}}' + accountId: 3445 + incorporationApplication: + nameRequest: + legalType: BEN + nrNumber: '{{nr_num}}' + offices: + registeredOffice: + deliveryAddress: + streetAddress: delivery_address - address line one + addressCity: delivery_address city + addressCountry: CA + postalCode: H0H0H0 + addressRegion: BC + mailingAddress: + streetAddress: mailing_address - address line one + addressCity: mailing_address city + addressCountry: CA + postalCode: H0H0H0 + addressRegion: BC + recordsOffice: + deliveryAddress: + streetAddress: delivery_address - address line one + addressCity: delivery_address city + addressCountry: CA + postalCode: H0H0H0 + addressRegion: BC + mailingAddress: + streetAddress: mailing_address - address line one + addressCity: mailing_address city + addressCountry: CA + postalCode: H0H0H0 + addressRegion: BC + contactPoint: + email: no_one@never.get + phone: 123-456-7890 + parties: + - mailingAddress: + addressCity: Victoria + addressCountry: CA + addressRegion: BC + postalCode: V8W 3E6 + streetAddress: 200-940 Blanshard St + streetAddressAdditional: '' + officer: + email: severin@example.com + firstName: BCREGTEST Lucille + id: '2xy-bpc33' + lastName: TWENTY + middleName: '' + organizationName: '' + partyType: person + roles: + - appointmentDate: '2024-07-24' + roleType: Completing Party + - deliveryAddress: + addressCity: Burnaby + addressCountry: CA + addressRegion: BC + postalCode: V5E 1R9 + streetAddress: 6767 Burford St + streetAddressAdditional: '' + mailingAddress: + addressCity: Burnaby + addressCountry: CA + addressRegion: BC + postalCode: V5E 1R9 + streetAddress: 6767 Burford St + streetAddressAdditional: '' + officer: + firstName: Director + id: '2xy-bpc33' + lastName: Test + middleName: '' + organizationName: '' + partyType: person + roles: + - appointmentDate: '2024-07-24' + roleType: Director amalgamation-regular-request: summary: Amalgamation Regular Request value: From a55e1ec08c8ec6bfe8f5fc19870cb1759a8d00ec Mon Sep 17 00:00:00 2001 From: PaulGarewal Date: Tue, 30 Jul 2024 15:02:12 -0700 Subject: [PATCH 2/7] removed id from request body --- docs/oas/business.yaml | 2 -- 1 file changed, 2 deletions(-) diff --git a/docs/oas/business.yaml b/docs/oas/business.yaml index ce289c226a..42109d49a3 100644 --- a/docs/oas/business.yaml +++ b/docs/oas/business.yaml @@ -2938,7 +2938,6 @@ paths: officer: email: severin@example.com firstName: BCREGTEST Lucille - id: '2xy-bpc33' lastName: TWENTY middleName: '' organizationName: '' @@ -2962,7 +2961,6 @@ paths: streetAddressAdditional: '' officer: firstName: Director - id: '2xy-bpc33' lastName: Test middleName: '' organizationName: '' From 19acfbd999fe622ba88b2e5a67fa6ab851535d9e Mon Sep 17 00:00:00 2001 From: PaulGarewal Date: Tue, 30 Jul 2024 15:05:02 -0700 Subject: [PATCH 3/7] replaced date and nrnum --- docs/oas/business.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/oas/business.yaml b/docs/oas/business.yaml index 42109d49a3..61e0fd17ee 100644 --- a/docs/oas/business.yaml +++ b/docs/oas/business.yaml @@ -2891,12 +2891,12 @@ paths: certifiedBy: API Specs email: no_one@never.get name: incorporationApplication - date: '{{today}}' + date: 2024-07-25T19:54:02.949741+00:00 accountId: 3445 incorporationApplication: nameRequest: legalType: BEN - nrNumber: '{{nr_num}}' + nrNumber: NR 1234567 offices: registeredOffice: deliveryAddress: From fa08d8906717b2a75df4f6889fa964ac1b2870e5 Mon Sep 17 00:00:00 2001 From: PaulGarewal Date: Tue, 30 Jul 2024 15:05:56 -0700 Subject: [PATCH 4/7] replaced account id with mock val --- docs/oas/business.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/oas/business.yaml b/docs/oas/business.yaml index 61e0fd17ee..6cda3c98ed 100644 --- a/docs/oas/business.yaml +++ b/docs/oas/business.yaml @@ -2448,7 +2448,7 @@ paths: business: identifier: Tqcbbbc157 header: - accountId: 3445 + accountId: 6164 affectedFilings: [] availableOnPaperOnly: false certifiedBy: API Specs @@ -2892,7 +2892,7 @@ paths: email: no_one@never.get name: incorporationApplication date: 2024-07-25T19:54:02.949741+00:00 - accountId: 3445 + accountId: 6164 incorporationApplication: nameRequest: legalType: BEN From 9c82a7558e651fd694fc28419013fea945066741 Mon Sep 17 00:00:00 2001 From: PaulGarewal Date: Tue, 30 Jul 2024 15:07:08 -0700 Subject: [PATCH 5/7] fixed indent --- docs/oas/business.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/oas/business.yaml b/docs/oas/business.yaml index 6cda3c98ed..569f2405c9 100644 --- a/docs/oas/business.yaml +++ b/docs/oas/business.yaml @@ -2465,7 +2465,7 @@ paths: name: incorporationApplication status: DRAFT submitter: mocked submitter - incorporationApplication: + incorporationApplication: contactPoint: email: no_one@never.get phone: 123-456-7890 From 49a25a23a43b4640a3fc0bc0654729a57ee5fc4d Mon Sep 17 00:00:00 2001 From: PaulGarewal Date: Wed, 31 Jul 2024 08:08:37 -0700 Subject: [PATCH 6/7] added 401 unauthorized response --- docs/oas/business.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/docs/oas/business.yaml b/docs/oas/business.yaml index 569f2405c9..becca3b2b9 100644 --- a/docs/oas/business.yaml +++ b/docs/oas/business.yaml @@ -2876,6 +2876,11 @@ paths: value: errorMessage: API backend third party service error. rootCause: message:You are not authorized to submit a filing for TgtPxoS4FF. + incorporation-unauthorized-response: + summary: Incorporation - Not Authorized To Submit Response + value: + errorMessage: API backend third party service error. + rootCause: message:You are not authorized to submit a filing for TgtPxoS4FF. description: Submitting a creation filing for a business will create that type of business if it is a fully valid filing and payment has been completed. requestBody: content: From 7a68089e9624a7c2c0e146c2084d2045e553111d Mon Sep 17 00:00:00 2001 From: PaulGarewal Date: Wed, 31 Jul 2024 08:53:59 -0700 Subject: [PATCH 7/7] changed date string types and values --- docs/oas/business.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/oas/business.yaml b/docs/oas/business.yaml index becca3b2b9..7b2d54a9be 100644 --- a/docs/oas/business.yaml +++ b/docs/oas/business.yaml @@ -2454,7 +2454,7 @@ paths: certifiedBy: API Specs colinIds: [] comments: [] - date: '2024-07-25T16:17:57.191108+00:00' + date: '2024-07-25' deletionLocked: false effectiveDate: '2024-07-25T16:17:57.191129+00:00' email: no_one@never.get @@ -2896,7 +2896,7 @@ paths: certifiedBy: API Specs email: no_one@never.get name: incorporationApplication - date: 2024-07-25T19:54:02.949741+00:00 + date: '2024-07-25' accountId: 6164 incorporationApplication: nameRequest: