New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

why not count the value over 250 #42

Open

Usernamezhx opened this issue Oct 29, 2024 · 1 comment

Usernamezhx commented Oct 29, 2024

fast-colorthief/cpp/fast_colorthief_backend.cpp

Line 32 in 92eda78

    
           if (data[pixel_index * 4] <= 250 || data[pixel_index * 4 + 1] <= 250 || data[pixel_index * 4 + 2] <= 250) {

why not count the value over 250

Owner

bedapisl commented Oct 29, 2024

Hello, because I want to maintain compatibility with original colorthief, which does the same (https://github.com/fengsp/color-thief-py/blob/master/colorthief.py#L72)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment