[Release Process]: Please implement a tag and release workflow and have it fail early if the version is wrong

[Kangie]

The version number did not get an update before being tagged as 2.2.0:

beets/pyproject.toml

Line 3 in 01f1faf

version = "2.1.0"

Since #5531 means that the PyPi tarball is unsuitable for me as a dowstream I've had to resort to seding pyproject.toml (etc).

Proposed solution

Please come up with a solution that produces usable GitHub release artefacts.

[snejus]

This is weird, didn't realize I thought I addressed this issue with 2.1.0 release, but it seems like it's occurring again. Will get this fixed asap.

[snejus]

Could you confirm that moving the tag to the correct commit would fix your issue?

[Kangie]

Could you confirm that moving the tag to the correct commit would fix your issue?

I've worked around it downstream using sed - It's more making sure that a future release can't go ahead if the version and tag aren't in alignment to catch this in future :)

[snejus]

This makes sense. If you have time, feel free to have a look at the PR that fixes this issue.

[Serene-Arc]

This is a weird bug that comes from having the tagging action in the wrong part, which @snejus found and fixed! I introduced it when I made the workflow. It's been an issue for the last few releases and we usually fix it manually. Hopefully this means that it won't be an issue in the future.