Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameters like --dab_rate can't be set from cmd line bc they are bool #8

Open
al-zatv opened this issue Jun 9, 2022 · 0 comments
Open

Comments

@al-zatv
Copy link

al-zatv commented Jun 9, 2022

look at parameters below. They really became bool, i find this bug while debugging it.
'''
if name == 'main':
parser = argparse.ArgumentParser()
parser.add_argument("action", help="train|eval|predict|tensorize|preprocess", type=str)
...
parser.add_argument("--updates", help="number of training updates to perform", default=default_config.updates, type=bool)
parser.add_argument("--period", help="validation period in updates", default=default_config.period, type=bool)
parser.add_argument("--lr", help="learning rate", default=default_config.lr, type=bool)
parser.add_argument("--dab-rate", help="drop at boundaries rate", default=default_config.dab_rate, type=bool)
config = Config(**parser.parse_args().dict)

main(config, config.action, config.action_args)

'''

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant