-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Infer module path #198
Comments
Sorry for the late reply. It would be great if you can contribute to this feature, it's very useful. Thank you for your help! |
OK, cool! I would look if I can somehow extract the module path which the |
I sent my message yesterday without having a look at your reproducer project. Now I finally took the time to look at it and realized that I had misunderstood the problem.
|
Yeah, |
In my application, I'm using service modules and separate modules which provide those services. Gradle 7.2 itself is able to infer the module path for the application by looking at the dependencies - service implementations show up as
runtime project(...)
dependencies. Example:I'm using the
badass-jlink-plugin:2.24.2
, which however does not infer the module path for those service implementations. It's working fine if I specify the module path in acustomImage
declaration. Example:This can get a bit cumbersome with more and more modules added to the application. Wouldn't it be possible to derive the module path from the application's dependencies? I would be glad to contribute to that feature.
I have pushed a reproducer project here: https://github.com/oliver-brm/jpms-hello.git. To reproduce:
customImage
declaration frombuild.gradle
jlink
orjpackage
taskbuild/image/bin/greeting
, it will print:The text was updated successfully, but these errors were encountered: