Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans to support both Native driver and Tedious? #56

Open
smiziara opened this issue Aug 12, 2021 · 6 comments
Open

Plans to support both Native driver and Tedious? #56

smiziara opened this issue Aug 12, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@smiziara
Copy link

Hello,

Do you have any plans to provide support for both the Native V8 driver for MSSQL alongside with the current one (Tedious)?

Im interested in using the Native version, so if you are not currently work on this, can we fork and add this functionality, or would you consider a PR?

Thanks.

@bestlong
Copy link
Owner

https://www.npmjs.com/package/msnodesqlv8
This one ?

PR is welcome.

@smiziara
Copy link
Author

smiziara commented Aug 12, 2021 via email

@Steve-Mcl
Copy link
Collaborator

@bestlong are we sure we want to do this? I believe msNodesqlV8 needs to build on a user's system (so requires a user to have build tools ore-installed so that bindings can be compiled) and it has prerequisites (e.g. ODBC)

@smiziara how would you propose to provide users a choice between tedious and msNodesqlV8?

@smiziara
Copy link
Author

smiziara commented Aug 13, 2021 via email

@Steve-Mcl
Copy link
Collaborator

@smiziara that seems like a reasonable approach. I would have been worried if it were a direct dependency.

Look forward to PR

@bestlong
Copy link
Owner

@Steve-Mcl Wait until we see the PR to decide.

@Steve-Mcl Steve-Mcl added the enhancement New feature or request label Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants