Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRE_NMS_LIMIT #4

Closed
yuriyOn opened this issue Apr 10, 2019 · 4 comments
Closed

PRE_NMS_LIMIT #4

yuriyOn opened this issue Apr 10, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@yuriyOn
Copy link

yuriyOn commented Apr 10, 2019

I got an error while running first evaluate.ipynb and then train.ipynb that PRE_NMS_LIMIT is not defined in the model.py. I have found in the original Mask R-CNN implementation that it should be set to 6000. You should add the parameter to avoid the error to both files.

@michaelisc
Copy link
Member

It seems you are using a more recent version of the Matterport Mask R-CNN than included in the repo. The PRE_NMS_LIMIT was fixed to 6000 back then. Can you test if any other things fail with the newer version of Mask R-CNN? If this is the only thing we have to change I am happy to add this.

@michaelisc michaelisc added the enhancement New feature or request label Apr 10, 2019
@yuriyOn
Copy link
Author

yuriyOn commented Apr 10, 2019

Another problem is listed in issue #1 and it is solved by replacing the Mask_RCNN directory with the latest version.

@michaelisc
Copy link
Member

The problem with PRE_NMS_LIMIT should be fixed with commit 2a677a9. Now the settings from the original Config class from Mask_RCNN/mrcnn/config.py are inherited.

@michaelisc
Copy link
Member

We should still update lib/Mask_RCNN. See issue #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants