Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📎 Remove postinstall script for @biomejs/biome #4854

Closed
SuperchupuDev opened this issue Jan 7, 2025 · 2 comments · Fixed by #4887
Closed

📎 Remove postinstall script for @biomejs/biome #4854

SuperchupuDev opened this issue Jan 7, 2025 · 2 comments · Fixed by #4887
Assignees
Labels
A-CLI Area: CLI good first issue Good for newcomers

Comments

@SuperchupuDev
Copy link
Member

SuperchupuDev commented Jan 7, 2025

Description

Biome currently has a postinstall script that checks if it's being installed in a supported platform. If it doesn't, it will log a warning to the console in some package managers. This check is also being done separately, every time the package is run.

Considering the nature of postinstall scripts, and the fact that some package managers such as pnpm are starting to block lifecycle scripts in dependencies by default, I propose removing this script to avoid duplicated processing and allow installations to be ever so slightly faster. If a user is using an unsupported platform, they will notice anyways as soon as they run biome (and actually they might not even notice it on postinstall right now because the postinstall script doesn't return an error code). It would also make biome installations less dependent on node

@SuperchupuDev SuperchupuDev added the good first issue Good for newcomers label Jan 7, 2025
@ematipico ematipico added the A-CLI Area: CLI label Jan 8, 2025
@ekoeditaa
Copy link
Contributor

I would love to pick this up. Thanks!

@nhedger nhedger assigned nhedger and ekoeditaa and unassigned nhedger Jan 13, 2025
@nhedger
Copy link
Member

nhedger commented Jan 13, 2025

Thanks, I assigned it to you!

@nhedger nhedger linked a pull request Jan 13, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants