Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup cancelling Figma sidepanel rename mode #1920

Open
brainwo opened this issue Aug 9, 2024 · 1 comment
Open

Popup cancelling Figma sidepanel rename mode #1920

brainwo opened this issue Aug 9, 2024 · 1 comment

Comments

@brainwo
Copy link

brainwo commented Aug 9, 2024

Not sure this should be extension feature or a browser feature, but it would be helpful if there is an option to specify "blacklisted sites". This will allow users to list domain/page where they don't want this extension to be enabled on.

I find it's annoying when I work using Figma and also in the same time need 10ten-ja-reader to be enabled in sites in which I copy some words from as hiragana.

Clicking on editable text makes difficult, I need few times to make it work. Disabling and enabling the extension via keyboard shortcut also isn't ideal.

2024-08-0912:25:34UTC_firefox mp4

Alternative solution I'm considering is to allow disabling words lookup in <input> element.

@brainwo brainwo changed the title Disable extension on Figma Popup cancelling Figma sidepanel rename mode Aug 11, 2024
@birtles
Copy link
Member

birtles commented Aug 13, 2024

That certainly looks annoying to have it pop up there!

I haven't personally encountered that situation too much since I have 10ten always on and use Ctrl to enable it just when I want to look something up.

This setting here:

image

I think we could add a feature to disable 10ten for various sites, however we should probably do that as part of reworking how it gets enabled in general. For the Safari version we use activeTab mode which means it's only enabled on tabs the user explicitly enables it for. However, many Safari users find that annoying.

It would be nice if we can make it start off in activeTab mode and allow users to expand the permissions to all sites or select sites only (and potentially exclude sites at the same time).

Alternatively, if it's never useful to lookup Japanese text in the Figma sidebar, we could specifically make 10ten ignore that content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants