Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share comment exports the truncated URL as shown in comment view #71

Open
mdaniel opened this issue May 12, 2014 · 1 comment
Open

Share comment exports the truncated URL as shown in comment view #71

mdaniel opened this issue May 12, 2014 · 1 comment
Assignees
Labels
Milestone

Comments

@mdaniel
Copy link

mdaniel commented May 12, 2014

I realize that's a terrible summary, but here's the way to see what I mean:

  1. Navigate to a comment with a long URL such as this
  2. Observe that the comment view shows the truncated URL with ellipsis at the end
  3. Long press on the comment and chose share
  4. Any text receiver will demonstrate the issue: Gmail, SMS, Keep, etc
  5. Observe that the shared text also shows the truncated URL meaning one cannot see the full URL without navigating to the HN comment "item" link first

The optimal outcome would be to get the "source" of the comment and share that (since the source of the comment obviously knows the real URL or one couldn't follow the link).

@pkillian
Copy link
Collaborator

I understand the issue completely; it's most likely a simple oversight as to which field we pull the share link from in that activity. I'll add this to the next milestone and once I find the time to knock out a bunch of issues, I'll tackle this one as well.

Thanks!

@pkillian pkillian added this to the 2.2.0 milestone May 12, 2014
@pkillian pkillian added the bug label May 12, 2014
@pkillian pkillian self-assigned this May 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants