refactor(simln-lib): Parse address detecting if starts with https #212
Conversation
There was a problem hiding this comment.
One approach comment - I think we can live without the type alias (but this opinion is not strongly held so open to motivation for is).
Let's also update the readme to remove all the https prefixes from our examples and the requirement "Note that node addresses must be declare with HTTPS transport". Generally try to keep in the good habit of updating readme along with code so that we don't get too out of date.
simln-lib/src/lib.rs
Outdated
| @@ -48,6 +48,9 @@ pub enum NodeId { | |||
| Alias(String), | |||
| } | |||
|
|
|||
| #[derive(Serialize, Debug, Clone)] | |||
| pub struct Address(String); | |||
There was a problem hiding this comment.
I think that we can live without this type alias and just use #[serde(with = "serializers::serde_address")] to point to custom serialization/deserialization of a String to reduce LOC a little.
|
Also a small nitpick on commit naming (which is unconventional mostly personal preference, so feel free to ignore), generally we've been using the structure: Also in this case it's not actually a refactor, it's a (tiny) |
f3r10
force-pushed
the
do_not_require_https_in_address
branch
from
6a2fa2c to
07be566
Compare
f3r10
force-pushed
the
do_not_require_https_in_address
branch
from
4befd29 to
27600ce
Compare
fix #154
Detect if the parsed address starts with the https protocol; if not, add it without requiring a user to do it.