Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace legacy api for symbols/symbolsDetails #23

Open
gasolin opened this issue Apr 2, 2019 · 4 comments
Open

replace legacy api for symbols/symbolsDetails #23

gasolin opened this issue Apr 2, 2019 · 4 comments
Assignees

Comments

@gasolin
Copy link

gasolin commented Apr 2, 2019

To help reduce platform load, please use https://api.bitfinex.com/v2/conf/pub:list:currency,pub:map:currency:label,pub:map:currency:unit,pub:list:pair:exchange

instead of v1 legacy request in https://github.com/bitfinexcom/bfx-api-node-rest/blob/master/lib/rest2.js#L858

@f3rno
Copy link
Contributor

f3rno commented May 20, 2019

@gasolin this would change the returned data for symbol details; currently this is the structure:

  {
    "pair": "eususd",
    "price_precision": 5,
    "initial_margin": "30.0",
    "minimum_margin": "15.0",
    "maximum_order_size": "30000.0",
    "minimum_order_size": "2.0",
    "expiration": "NA",
    "margin": false
  }

Can you confirm this is OK?

@f3rno f3rno added the question Further information is requested label May 20, 2019
@gasolin
Copy link
Author

gasolin commented May 20, 2019

I think its not right to return different things that broken the existing integration.

If provide equivalent through v2 API is not possible, maybe it worths to create an alternative v2 API (if make sense)

@f3rno
Copy link
Contributor

f3rno commented May 20, 2019

@gasolin makes sense, I will forward internally

@f3rno
Copy link
Contributor

f3rno commented May 20, 2019

Pending backend update.

@f3rno f3rno added pending-backend and removed question Further information is requested labels May 20, 2019
@f3rno f3rno self-assigned this May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants