Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Bitbucket Server #12

Open
KatharinaSick opened this issue Jan 18, 2023 · 1 comment
Open

Support for Bitbucket Server #12

KatharinaSick opened this issue Jan 18, 2023 · 1 comment

Comments

@KatharinaSick
Copy link

Hi,

since Bitbucket Server now (finally) supports OAuth2, it would be great to add support for it to this strategy as well. I already tried if this strategy works with Bitbucket Server and everything until parsing the user profile succeeds. Parsing the user profile unfortunately fails, because Bitbucket Server has a different user profile response format than Bitbucket Cloud (docs).

This means, we could add support for Bitbucket Server by editing the profile.js. Would you be open for a contribution from my side?
My plan would be to add a boolean flag to the strategy whether one is authenticating against Bitbucket Server (false by default) and if set, the profile would get parsed differently.

@KatharinaSick
Copy link
Author

@gtanner @tqc would you accept a PR that adds Bitbucket Server support?

Sorry for pinging you directly, but I would really like to solve this with a PR rather than a new strategy that is forked from yours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant