Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use base58-native as an npm dependency #411

Closed
deckar01 opened this issue Jul 6, 2014 · 2 comments
Closed

Use base58-native as an npm dependency #411

deckar01 opened this issue Jul 6, 2014 · 2 comments

Comments

@deckar01
Copy link

deckar01 commented Jul 6, 2014

Replace the bundled lib base58.js with the npm dep base58-native.

Child issue of #410.
@deckar01
Copy link
Author

deckar01 commented Jul 6, 2014

After replacing base58.js with base58-native, the tests failed due to the bug fix #402 not being present in base58-native.

The PR for this issue can't be opened until gasteve/node-base58#9 is merged, due to the failing tests.

@maraoz
Copy link
Contributor

maraoz commented Dec 19, 2014

outdated

@maraoz maraoz closed this as completed Dec 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maraoz @deckar01