Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Order Improvements #318

Closed
roma219 opened this issue Dec 18, 2018 · 4 comments
Closed

New Order Improvements #318

roma219 opened this issue Dec 18, 2018 · 4 comments
Assignees

Comments

@roma219
Copy link
Contributor

roma219 commented Dec 18, 2018

  1. Trim number after the . after calculated precised amount right before placing order
  2. Make max length of inputs 9 - should be probably done throught some directive and modifying SimpleInput, or in actions when setting price/get/spent. e.g.:
    parseFloat(String(0.92342783462364234).substring(0,9)) (New order: price format #314)
  3. Prevent placing order when user doesn't have anough BTS & show some kind of indicator about it. Also when spending BTS subtract bts fee from max amount available.

image (#315)
6) Market order doesn't work properly in Sell mode
image

@roma219
Copy link
Contributor Author

roma219 commented Dec 18, 2018

re: 9
Probably use something like this directive and apply it via props (similar to currently used restrict directive):
http://www.webspeaks.in/2017/07/custom-directives-in-vuejs.html

@hisinbox
Copy link
Contributor

please shift volume fields a bit away (left/right) from the price field - to make sure that long volume entries do not intersect the circle (see the original mockup) @roma219 @plapinp17

@hisinbox
Copy link
Contributor

also I noticed that price field (and circles) are to close to the button - there must be more space between the button and the circle @roma219 @plapinp17

@youaresofunny
Copy link
Contributor

@hisinbox
Please make some separate issue if comments are actual
This task wasn't about markup)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants