Add TCP feature #33
Open
Add TCP feature #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @blahgeek, any ideas why the test pipeline's failing? |
|
Ah the unit tests are not updated yet. It should not matter though. |
eval-exec
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31
This adds experimental support for TCP transport.
It connects to language server using TCP, do the translation, and also serve from TCP itself.
Using this mode with lsp-mode is a little bit complex than stdio, since there does not seem to be an unified way to modify the port or launching command. Personally I don't use any language servers using the TCP transport so I don't really know how to test it. I would appreciate any help on testing or recommendations about configuration on the elisp side.
The rough steps on how to use it:
emacs-lsp-booster --tcp -- <server_addr> <listen_addr>, where "server_addr" is the address that the original language server is listening on (e.g.127.0.0.1:1044), and "listen_addr" is any address you pick for emacs-lsp-booster to listen on (e.g.127.0.0.1:1045)127.0.0.1:1045) by modifying language-server-specific variables (e.g.lsp-cobol-port)