Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change image tag/digest only #19

Open
bluebrown opened this issue Jul 15, 2023 · 3 comments
Open

Change image tag/digest only #19

bluebrown opened this issue Jul 15, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@bluebrown
Copy link
Owner

bluebrown commented Jul 15, 2023

Currently, kobold updates the full image ref. This leads to the default registry being added to image for non fully qualified domain names. It would be better if only the tag / digest would be changed.

@bluebrown bluebrown added the enhancement New feature or request label Jul 15, 2023
@github-actions github-actions bot added the triage requires review label Jul 15, 2023
@bluebrown bluebrown removed the triage requires review label Jul 27, 2023
@rossigee
Copy link
Contributor

rossigee commented Apr 2, 2024

How would we like to do this?

So, currently, by default, we only support full image URIs like this...

image: test.azurecr.io/nginx # kobold: tag: latest; type: exact

Would something like the following work to support parts?

image:
  repository: ...
  tag: "1.0" # kobold: tag: ^1; type: semver; part: tag
  digest: "" # kobold: tag: ^1: type: semver; part: digest

@bluebrown
Copy link
Owner Author

How would we like to do this?

So, currently, by default, we only support full image URIs like this...

image: test.azurecr.io/nginx # kobold: tag: latest; type: exact

Would something like the following work to support parts?

image:
  repository: ...
  tag: "1.0" # kobold: tag: ^1; type: semver; part: tag
  digest: "" # kobold: tag: ^1: type: semver; part: digest

aah this one. Yes I have though about that as well. Its not what this issue here is about but its definilty something that would make sense

@bluebrown
Copy link
Owner Author

The logic for this is here https://github.com/bluebrown/kobold/tree/main/krm in filter.go and comment.go. If you want to take a stab @rossigee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants