Commit message intermittently missing package name

[tsmalls93]

I have noticed on a couple of occasions that the commit message is just "chore(kobold): ". I am not sure of the cause. The issue appears to be intermittent, because often when I re-trigger the webhook it works.

[bluebrown]

Hi, thanks for reporting. There was a pull request recently regarding to the messages. It was a bit messy. I tried to clean up afterwards but it may have some bugs.

[bluebrown]

related code is around here

kobold/krm/filter.go

Line 51 in d77d877

c := Change{

and here

kobold/task/handler.go

Line 48 in d77d877

msg, err = GetCommitMessage(changes)

[rossigee]

Maybe related #67

[tsmalls93]

Apologies for the delay in response. I have confirmed that this bug is still occurring in 0.4.1.

[bluebrown]

Yeah I figured that missing error handle wasnt the cause. Its very unlikely it accually error something like strings.Builder.Write, or what it was.

Does it actually change images when it commits those messages?

[tsmalls93]

Yeah, it still updates the images.

[tsmalls93]

Unfortunately, it looks like this is still an issue.

[bluebrown]

Can you share the actual image ref? You can anonymize some parts,
but the overall structure would be interesting.

[tsmalls93]

Sure. Our repo isn't available to the internet, but the image in this instance was nexus.kub.org/backstage:1.10.1. My pipeline looks like this:

    [[channel]]
    name = "nexus"
    decoder = "kub.nexus@v1"

    [[decoder]]
    name = "kub.nexus@v1"
    script = """
    load("encoding/json.star", "json")

    def main(input):
      data = json.decode(input)
      action = data.get("action", None)
      if action != "CREATED" and action != "UPDATED":
          fail("skipping action: " + action)
      component = data.get("component", None)
      name = component.get("name", None)
      version = component.get("version", None)
      image = "nexus.kub.org/{}:{}".format(name, version)
      output = [image]
      return output
    """

    [[pipeline]]
    name = "argocd-devops"
    repo_uri = "[email protected]:platform/argocd-devops?ref=main"
    dest_branch = "kobold"
    channels = ["nexus"]
    post_hook = "kub.github-pr@v1"

    [[post_hook]]
    name = "kub.github-pr@v1"
    script = """
    load("http.star", "http")

    def main(repo, src_branch, dest_branch, title, body, changes, warnings):
      parts = repo.split("/")
      name = parts[-1]
      owner = parts[-2].split(":")[-1]

      url = "https://github.kub.org/api/v3/repos/" + owner + "/" + name + "/pulls"

      headers = {
          "Accept": "application/vnd.github+json",
          "Authorization": "Bearer " + host_env["GITHUB_TOKEN"],
          "X-GitHub-Api-Version": "2022-11-28",
      }

      data = {"title": title, "body": body, "head": dest_branch, "base": src_branch}

      res = http.post(url, headers = headers, json_body = data)
      if res.status_code != 201:
          print("hook: pr failed: base=" + src_branch + " head=" + dest_branch + " repo=" + repo)
          return res.body()

      print("github pr created: " + res.json()["url"])
      return None
    """

This relevant parts of the webhook payload are as follows:

{
    "action": "CREATED",
    "component": {
        "name": "backstage",
        "version": "1.10.1"
    }
}