Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: mission planning: dragging and removing waypoints doesn't work #1550

Open
1 task done
ES-Alexander opened this issue Jan 8, 2025 · 4 comments
Open
1 task done
Assignees
Labels
mission-planning ui UI related issues

Comments

@ES-Alexander
Copy link
Contributor

Bug description

  1. Dragging mission waypoints drags a circle but not the point label or the lines connecting it to the rest of the path
  2. Points are labelled with 1-indexing on the map, and 0-indexing in the list on the right side
  3. Deleting a point deletes the label and list entry, but keeps the line
  4. Waypoint labels also seem to have huge padding for no reason
Screenshot 2025-01-08 at 6 02 52 pm

Steps to reproduce

  1. Open Mission Planning mode
  2. Add some mission waypoints
  3. Try to drag them
  4. Try to delete them

Primary pain point(s)

Mission planning is much harder if the waypoints aren't editable, and if the labels are so big they have significant overlap.

Additional context

No response

Prerequisites

  • I have checked to make sure that a similar request has not already been filed or fixed.
@patrickelectric
Copy link
Member

Same issue here

@ES-Alexander ES-Alexander removed the bug label Jan 17, 2025
@rafaellehmkuhl
Copy link
Member

Can confirm. Will be in our quarter milestone.

@ArturoManzoli
Copy link
Contributor

Bug description

  1. Dragging mission waypoints drags a circle but not the point label or the lines connecting it to the rest of the path
  2. Points are labelled with 1-indexing on the map, and 0-indexing in the list on the right side
  3. Deleting a point deletes the label and list entry, but keeps the line
  4. Waypoint labels also seem to have huge padding for no reason

1- Solved in the first mission planning refactor PR-1469;
2- The right side waypoints panel was replaced by a sliding configuration panel, as the one present on the Edit Mode to configure input widgets - PR-1523;
3- Also fixed on - PR-1523;

4- I suspect this issue is related to a lifecycle problem. It loads the correct CSS properties only after a page refresh. My suggestion is to temporarily add an auto refresh until we find the root cause of the problem.

With the auto refresh logic added (also showing the issues from 1 to 3 solved):

Screenshare.-.2025-01-30.5_09_01.PM.mp4

@rafaellehmkuhl
Copy link
Member

rafaellehmkuhl commented Jan 30, 2025

Bug description

  1. Dragging mission waypoints drags a circle but not the point label or the lines connecting it to the rest of the path
  2. Points are labelled with 1-indexing on the map, and 0-indexing in the list on the right side
  3. Deleting a point deletes the label and list entry, but keeps the line
  4. Waypoint labels also seem to have huge padding for no reason

1- Solved in the first mission planning refactor PR-1469;
2- The right side waypoints panel was replaced by a sliding configuration panel, as the one present on the Edit Mode to configure input widgets - PR-1523;
3- Also fixed on - PR-1523;

4- I suspect this issue is related to a lifecycle problem. It loads the correct CSS properties only after a page refresh. My suggestion is to temporarily add an auto refresh until we find the root cause of the problem.

With the auto refresh logic added (also showing the issues from 1 to 3 solved):

I've seen problems 1 and 3 yet happening after we merged #1523. It is intermittent. Happens on some boots, not always.

Edit: just got it on master.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mission-planning ui UI related issues
Projects
None yet
Development

No branches or pull requests

4 participants