Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Icons in lower graphic modes #803

Open
Bariossimo opened this issue Jan 19, 2025 · 3 comments
Open

Broken Icons in lower graphic modes #803

Bariossimo opened this issue Jan 19, 2025 · 3 comments

Comments

@Bariossimo
Copy link
Contributor

Some icons didn't look correctly in lower graphic modes:

1. Preferences / Kid Guard in "CGA 640x200 Mono"-Mode
Image

2. Desktop / Computer in "IBM MCGA 640x480 Mono"- and "CGA 640x200 Mono"-Mode
Image

3. World / Extras / File Transfer in "EGA 640x350 16-color" or lower Modes
Image

@Bariossimo
Copy link
Contributor Author

The first and the third sub-issue can be fixed.

The second one does not occur, if there is a white background-color set instead of a background-picture. But it occurs also if there is a black background-color set. So, if you are CGA- or MONO-user you had to set the background to white!

But wait.. the other icons on desktop did also not appear completly correct. Nearby at "MyComputer"-Folder is the "Document"-Folder. The structure of the monikers NDMyComputerSCGAMoniker and NDDocumentSCGAMoniker is comparable. But they were painted very differently on screen, because system selects probably an NDDocumentSCMoniker instead of the ...CGA...-one and I don't know why this happens. Anyone any ideas?

Image

@bluewaysw
Copy link
Owner

Only the SC version is included for Document if GPC is define, what it likely is:

Image

@Bariossimo
Copy link
Contributor Author

Oh, thank you. My guess was that GPC isn't defined as true.
Removing all these "#ifdef GPC" will be a really big task..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants