Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit root scroller was unexpected #5

Open
jakearchibald opened this issue Sep 6, 2019 · 1 comment
Open

Implicit root scroller was unexpected #5

jakearchibald opened this issue Sep 6, 2019 · 1 comment

Comments

@jakearchibald
Copy link

On https://proxx.app, the URL-hiding behaviour was unwanted during games because the viewport height only changes once the URL bar is fully hidden/shown. This causes anything fixed to the bottom of the viewport to snap around in a really ugly way.

Sometimes this is acceptable for content sites, but in the game, scrolling up & down would happen frequently, and the viewport size changing became disruptive, or worse, resulted in controls being outside the visible viewport.

We tried to fix it by creating a different element for the scrolling, but since it was full size, we ran into implicit root scrolling. In the end, we worked around it by making the scrolling element 1px less than full size.

It feels like there should be a less hacky way around this. Maybe a way to prevent the URL bar hiding regardless of which element is scrolling?

@bokand
Copy link
Owner

bokand commented Sep 6, 2019

Yeah, there's definitely cases where it shouldn't activate. However, I'm a bit confused why the URL bar was hideable at all; normally the page has to have scrollable overflow or else the URL bar won't be movable. I'd imagine in a game (indeed, in proxx.app) I don't imagine there to be overflow. Do you know what was happening there? Perhaps there was some unintended overflow that allowed some movement?

Is there a test-URL or some small changes I can make in dev tools to see the problem myself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants