Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request aria-hidden="true" #216

Open
AxelBriche opened this issue Feb 16, 2021 · 2 comments
Open

Request aria-hidden="true" #216

AxelBriche opened this issue Feb 16, 2021 · 2 comments

Comments

@AxelBriche
Copy link

AxelBriche commented Feb 16, 2021

Can you please add aria-hidden="true" by default on tag when a text is provided for accessibility or add a configuration for add aria-hidden by default?

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-hidden_attribute

@AxelBriche AxelBriche changed the title Request Request aria-hidden="true" Feb 16, 2021
@mockdeep
Copy link

This would be great! We end up adding it manually to all of our icons.

@rmm5t
Copy link
Collaborator

rmm5t commented Jan 31, 2022

A PR for this would be much appreciated.

I think aria-hidden=true as the default would be fine as long as an option of hidden: false can also be passed to fa_icon to disable this new default attribute. i.e. I can imagine a scenario where voicing shouldn't be suppressed for some uses of an icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants