Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal close button - Bootstrap 5.2x support #814

Closed
HarpunDK opened this issue Jun 1, 2022 · 1 comment
Closed

Modal close button - Bootstrap 5.2x support #814

HarpunDK opened this issue Jun 1, 2022 · 1 comment

Comments

@HarpunDK
Copy link

HarpunDK commented Jun 1, 2022

Button-close are rendered incorrect.

For Bootstrap 5.2x support, the following should be correct:
templates.closeButton value: '<button type="button" class="btn-close bootbox-close-button close" aria-hidden="true"></button>',
Bootbox.js (l:94-95)

Instead of: '<button type="button" class="bootbox-close-button close" aria-hidden="true">&times;</button>,'

This issue also exists in 5.1x i think.

Let me know if I should create a Pull request. Dont know if compatibility issues with lower versions of Bootstrap, how these are handled.

Thank you for a very nice library

@tiesont
Copy link
Member

tiesont commented Jun 1, 2022

This has been discussed before. For example, in #777

If you need Bootstrap 5 support, the closest available is the v6-wip branch, which seems to work, but I am still not quite ready to push that to master yet.

@tiesont tiesont closed this as completed Jun 1, 2022
@bootboxjs bootboxjs deleted a comment from YashPatkar Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants