New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use pixel thresholds relative to image size #302

Open

johnwlambert opened this issue Sep 16, 2021 · 1 comment

Collaborator

johnwlambert commented Sep 16, 2021 •

edited

Loading

Make pixel thresholds a function of the image size, to avoid treating 480p and 1296p images differently.

A good reference is http://phototour.cs.washington.edu/ModelingTheWorld_ijcv07.pdf:
We set the RANSAC outlier threshold to be 0.6% of the maximum image dimension, i.e., 0.006 max(image width,image height) (about six pixels for a 1024×768 image).

COLMAP users also complain about how in COLMAP this is hard-coded in their issue #1278.

Collaborator Author

johnwlambert commented Sep 16, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment