Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to make for code quality #356

Open
johnwlambert opened this issue Oct 18, 2021 · 0 comments
Open

Improvements to make for code quality #356

johnwlambert opened this issue Oct 18, 2021 · 0 comments

Comments

@johnwlambert
Copy link
Collaborator

  • Clarify in the HTML report what determines a "valid" image pair

  • Have 2 separate thresholds for R and U success? Put in place right before the results against the metric

  • Could add image-only metrics before Verifier Summary

  • Make a single table for each module (instead of FrontEnd Summary, have Verifier Summary, and PostProcessor Summary)

  • There should be a #avg number of inliers w.r.t. est model for Veriifer, and also separately for the PostProcessor

  • Create PostProcessor class in accordance with the graph
    Screen Shot 2021-10-18 at 7 01 56 PM

  • Decide upon what goes in side-by-side plots when comparing with ground truth

    • Should COLMAP # tracks go into COLMAP column? or should it be error w.r.t. COLMAP?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant