Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tslint rules problem in test folder #26

Open
bonzzy opened this issue Apr 3, 2018 · 5 comments
Open

Tslint rules problem in test folder #26

bonzzy opened this issue Apr 3, 2018 · 5 comments
Assignees

Comments

@bonzzy
Copy link
Contributor

bonzzy commented Apr 3, 2018

I propose one solution for custom tslint rules per folder.

We all have same custom ts-ignores in our tests, so i propose that we create tslint.json in test folder which extends tslint.json from root. There we can override some rules that are messing with our tests code.

I tested with PHPStorm and works good. What do you think?

Only thing we have to watch out is to set PHPStorm tslint config to "Search for tslint.json"

@vilimco
Copy link
Contributor

vilimco commented Apr 3, 2018

👍

1 similar comment
@leovujanic
Copy link
Contributor

👍

@krukru
Copy link
Contributor

krukru commented Apr 3, 2018

This is a good idea. Lets collect all the exceptions and turn it into a rule. It would be best to go right to a PR

@jakagacic
Copy link

I like it 👍

I have these 4 rules disabled in tests:

only-arrow-functions
no-unused-expression
max-line-length
no-big-function

@krukru
Copy link
Contributor

krukru commented Apr 5, 2018

OK, proposal is accepted. Jaka has a good list of starting rules. @bonzzy make it so

@ilesar ilesar removed their assignment Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants