You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 16, 2018. It is now read-only.
Hey! That's something that I wanted to do forever and having the monorepo
will help so much, as all repos will point to the root .eslintrc file!
I think two separate PRs would be best, the addition big the files will be
merged instantly whereas the other PR will require me to compile & test all
modules individually.
Thanks!!
On Fri, Mar 16, 2018, 7:22 PM Matias Barletta ***@***.***> wrote:
Hey team, botpress has linting rules .eslintrc and some scripts defined in
package.json that makes contributing and styling a lot easier :)
I tried to copy those to botpress-modules and there are a lot of changes
to do to comply with the same rules defined for botpress.
Should I do a PR adding the same .eslintrc found in botpress + the
recommended fixes?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#5>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQStDcuUQLK7i1h6zA5dzVN1KxkdESxks5tfEkpgaJpZM4Sujt5>
.
On Fri, Mar 16, 2018, 7:41 PM Sylvain Perron ***@***.***> wrote:
Hey! That's something that I wanted to do forever and having the monorepo
will help so much, as all repos will point to the root .eslintrc file!
I think two separate PRs would be best, the addition big the files will be
merged instantly whereas the other PR will require me to compile & test all
modules individually.
Thanks!!
On Fri, Mar 16, 2018, 7:22 PM Matias Barletta ***@***.***>
wrote:
> Hey team, botpress has linting rules .eslintrc and some scripts defined
> in package.json that makes contributing and styling a lot easier :)
>
> I tried to copy those to botpress-modules and there are a lot of changes
> to do to comply with the same rules defined for botpress.
>
> Should I do a PR adding the same .eslintrc found in botpress + the
> recommended fixes?
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#5>, or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABQStDcuUQLK7i1h6zA5dzVN1KxkdESxks5tfEkpgaJpZM4Sujt5>
> .
>
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hey team, botpress has linting rules .eslintrc and some scripts defined in package.json that makes contributing and styling a lot easier :)
I tried to copy those to botpress-modules and there are a lot of changes to do to comply with the same rules defined for botpress.
Should I do a PR adding the same .eslintrc found in botpress + the recommended fixes?
The text was updated successfully, but these errors were encountered: