Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links with text fragments broken #1

Open
bowernite opened this issue Aug 3, 2021 · 4 comments
Open

Links with text fragments broken #1

bowernite opened this issue Aug 3, 2021 · 4 comments

Comments

@petros
Copy link

petros commented Aug 3, 2021

I had an issue with my previously suggested URL. I switched to %28 and %29 encoding now and it seems to work everywhere.

[test](https://www.smashingmagazine.com/2014/09/balancing-line-length-font-size-responsive-web-design/#:~:text=65%20characters%20%282.5%20times%20the%20roman%20alphabet%29%20is%20often%20referred%20to%20as%20the%20perfect%20measure.%20derived%20from%20this%20number%20is%20the%20ideal%20range%20that%20all%20designers%20should%20strive%20for%3A%2045%20to%2075%20characters%20%28including%20spaces%20and%20punctuation%29%20per%20line%20for%20print)

test

@bowernite
Copy link
Owner Author

Ah, got it.

So, two thoughts:

  1. I’d still argue that GitBook has an issue here — other renderers (as seen in the second test in the issue description above — GitHub handles the unescaped paren just fine) do fine with unescaped parens, periods, etc.
  2. This is especially the case/exacerbated by the fact that utils in certain language (I’m using JavaScript, encodeURIComponent) which explicitly doesn’t escape parens, periods, etc.

image

I could always manually replace instances in my strings/links, but that seems like a workaround that would ideally be unecessary (for me and for others with the same issue).

@petros
Copy link

petros commented Aug 4, 2021

Thanks for the additional information. The question is whether GitHub diverges from the standard though. With GitHub Flavored Markdown. We can definitely research this a bit.

@bowernite
Copy link
Owner Author

bowernite commented Aug 4, 2021

Awesome! Yeah I’d be curious to see what other sites do. Like I said in my original support message, VS Code’s markdown preview also supports unescaped for these characters. And they specifically don’t subscribe to GitHub flavored markdown, but rather just CommonMark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants