Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow StyleContextStack.autopush() for large table #2732

Closed
estanglerbm opened this issue Jun 17, 2024 · 1 comment
Closed

Slow StyleContextStack.autopush() for large table #2732

estanglerbm opened this issue Jun 17, 2024 · 1 comment

Comments

@estanglerbm
Copy link

The styleProperties.forEach() in StyleContextStack.autopush() takes significant time for a large table of rows (i.e. 1,000 to 5,000 pages).

It's much faster (i.e. 14%) to skip creating the styleOverrideObject and just use the item itself.

This change would break three existing tests, however, that check for the number returned rather than for specific names (or lack thereof).

@liborm85
Copy link
Collaborator

liborm85 commented Aug 9, 2024

Fixed by PR #2733.
Released in version 0.2.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants