Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only serialize non-empty zeebe:taskHeader bindings #684

Closed
1 task
nikku opened this issue May 17, 2022 · 1 comment · Fixed by #748
Closed
1 task

Only serialize non-empty zeebe:taskHeader bindings #684

nikku opened this issue May 17, 2022 · 1 comment · Fixed by #748
Assignees
@nikku
Labels
bug Something isn't working Camunda Cloud element templates enhancement New feature or request spring cleaning Could be cleaned up one day

Comments

@nikku
Copy link
Member

nikku commented May 17, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe

The optional element template configuration is currently unsupported for zeebe:taskHeader bindings (#559). This forces me to serialize an empty header. Empty headers are not supported by the engine though:

screenshot bTri9i

Describe the solution you'd like

  • Empty headers shall not be serialized to prevent engine warnings

Describe alternatives you've considered

Empty task headers do not get rejected by the engine on deploy; hence this is something we could decide to ignore.

Additional context

Slack conversation that verifies this.
@nikku nikku added enhancement New feature or request element templates Camunda Cloud spring cleaning Could be cleaned up one day labels May 17, 2022
@pinussilvestrus pinussilvestrus added the backlog Queued in backlog label May 20, 2022 — with bpmn-io-tasks
@nikku
Copy link
Member Author

nikku commented Sep 1, 2022 •
edited
Loading

Checking against the engine (8.0 for example) it looks like there is nothing but optional: Header values MUST be non-empty:

screenshot bTri9i

So this is a bug on our end. I updated the description accordingly.

nikku added a commit that referenced this issue Sep 1, 2022
@nikku
fix: don't create headers with empty value
81b3102 
Closes #684
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Sep 1, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the backlog Queued in backlog label Sep 1, 2022
@nikku nikku changed the title Support optional for zeebe:taskHeader bindings Only serialize non-empty zeebe:taskHeader bindings Sep 1, 2022
@nikku nikku added the bug Something isn't working label Sep 1, 2022
@nikku nikku mentioned this issue Sep 1, 2022
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Sep 1, 2022
@fake-join fake-join bot closed this as completed in 9017ba5 Sep 1, 2022
@fake-join fake-join bot closed this as completed in #748 Sep 1, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
bug Something isn't working Camunda Cloud element templates enhancement New feature or request spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not serialize empty zeebe:header values bpmn-io/bpmn-js-properties-panel
2 participants
@nikku @pinussilvestrus