Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not sort entries alphabetically #311

Closed
nikku opened this issue Nov 29, 2023 · 1 comment · Fixed by #353 or bpmn-io/bpmn-js-properties-panel#1047
Closed

Do not sort entries alphabetically #311

nikku opened this issue Nov 29, 2023 · 1 comment · Fixed by #353 or bpmn-io/bpmn-js-properties-panel#1047
Labels
enhancement New feature or request

Comments

@nikku
Copy link
Member

nikku commented Nov 29, 2023

Is your feature request related to a problem? Please describe.

With the properties panel rewrite we decide to make sorting of entries alphabetically the default. Since then we've unbuilt in the BPMN properties panel the sorting for most parts.

We did it because sorting alphabetically for anything where ordering (in XML) has an execution semantic is dangerous (camunda/camunda-modeler#2932 (comment)). If at all, then users should have the chance to sort things manually.

Unfortunately the fact that sorting is the default continues to bite us, cf. camunda/camunda-modeler#3978. I therefore propose to disable sorting per default, and instead understand that the properties panel operates in a domain where deterministic, user chosen sorting is the standard.

Describe the solution you'd like

  • Disable alphabetically sorting (make shouldSort=false per default)

Describe alternatives you've considered

  • Get rid of sorting by some label all together

Additional context

Raised last (again) in the context of C7: camunda/camunda-modeler#3978.
@nikku nikku added the enhancement New feature or request label Nov 29, 2023
@nikku nikku self-assigned this Nov 29, 2023
@nikku nikku added the ready Ready to be worked on label Nov 29, 2023
This was referenced Nov 29, 2023
Open
Closed
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Nov 30, 2023
@nikku nikku added the ready Ready to be worked on label Dec 18, 2023 — with bpmn-io-tasks
@nikku nikku removed the in progress Currently worked on label Dec 18, 2023
@nikku nikku removed their assignment Feb 23, 2024
@nikku nikku added backlog Queued in backlog and removed ready Ready to be worked on labels Feb 23, 2024
@nikku
Copy link
Member Author

nikku commented Feb 23, 2024

This is not going to happen. Moving back to backlog.

@AlexanderSkrock AlexanderSkrock mentioned this issue Apr 26, 2024
Merged
5 tasks
@bpmn-io-tasks bpmn-io-tasks bot removed the backlog Queued in backlog label Apr 26, 2024
@AlexanderSkrock AlexanderSkrock mentioned this issue Apr 26, 2024
Merged
3 tasks
@nikku nikku added the needs review Review pending label May 22, 2024 — with bpmn-io-tasks
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label May 28, 2024
nikku pushed a commit that referenced this issue May 28, 2024
@AlexanderSkrock
feat: do not sort list items alphabetically (#353)
bb1cfb0 
This completely remove all sorting magic from the core properties panel. 
Userland is in charge of sorting.

Closes #311

chore: remove sorting from `ListGroup` component
chore: remove `compareFn` from `List` component
nikku added a commit that referenced this issue May 28, 2024
@nikku
feat: scroll focused element into view
03d4d2c 
Related to #311
@nikku nikku mentioned this issue May 28, 2024
Merged
nikku added a commit that referenced this issue May 28, 2024
@nikku
feat: scroll focused element into view
e54d1e8 
Related to #311
nikku added a commit that referenced this issue May 28, 2024
@nikku
feat: scroll focused element into view
523ccd6 
Related to #311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed sorting from ListGroup component
Do not sort list items alphabetically
1 participant
@nikku