Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(40) Groups aren't being used. Fix it #333

Open
Tracked by #238
ibihim opened this issue Nov 29, 2024 · 1 comment
Open
Tracked by #238

(40) Groups aren't being used. Fix it #333

ibihim opened this issue Nov 29, 2024 · 1 comment
Assignees
@ShazaAldawamneh
Labels
good first issue sig-auth-acceptance issues created during review for sig-auth-acceptance

Comments

@ibihim
Copy link
Collaborator

ibihim commented Nov 29, 2024 •
edited
Loading

What

Remove Groups from UserConfig in static.go

Use Groups in evaluation

Why

Doesn't seem to be used. Worth to double check.

Someone might configure groups and rely on it to work.

Reference

https://github.com/brancz/kube-rbac-proxy/pull/229/files#diff-90ae54b34ce395dcd2c182ea13a18a4979c09ae5dbbda98a1b24aa8abaa0f8b5R42
@ibihim ibihim mentioned this issue Nov 29, 2024
Open
58 tasks
@ibihim ibihim added good first issue sig-auth-acceptance issues created during review for sig-auth-acceptance labels Nov 29, 2024
@ShazaAldawamneh
Copy link

I can take this issue . @ibihim

@ShazaAldawamneh ShazaAldawamneh mentioned this issue Dec 2, 2024
Closed
@ShazaAldawamneh ShazaAldawamneh mentioned this issue Jan 7, 2025
Open
@ibihim ibihim changed the title (40) Not used? link (40) Groups aren't being used. Fix it Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShazaAldawamneh ShazaAldawamneh

Labels
good first issue sig-auth-acceptance issues created during review for sig-auth-acceptance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ibihim @ShazaAldawamneh