We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it less likely, that rewrite params are used. They should be only used if necessary, like in the context of prom-label-proxy.
The text was updated successfully, but these errors were encountered:
By @stlaz
Per our offline discussion, we should get rid of the query rewrites and stick with the header handling. I'd suggest the switch for the handling logic to operate like a mode switch rather than the bool. We would have two modes: 1. TerminatingEvaluation 2. PassthroughEvaluation or whatever names seem fitting, and document them properly, including the dangers of passthrough.
Per our offline discussion, we should get rid of the query rewrites and stick with the header handling.
I'd suggest the switch for the handling logic to operate like a mode switch rather than the bool. We would have two modes:
1. TerminatingEvaluation 2. PassthroughEvaluation or whatever names seem fitting, and document them properly, including the dangers of passthrough.
#346 (comment)
Sorry, something went wrong.
I wanted to make a step back to the discussion phase, this is why I closed the previous PR.
ibihim
No branches or pull requests
What
Make it less likely, that rewrite params are used. They should be only used if necessary, like in the context of prom-label-proxy.
Why
The text was updated successfully, but these errors were encountered: